Generalized blockReward and difficultyBombDelays config #9480
Conversation
sorpaas
added
A0-pleasereview 🤓
|
Do we want to backport this to 2.0 to have Constantinople available on the future stable branch? Edit, actually, I mark this blocker because it's required for the hard fork |
5chdn
added
B9-blocker 🚧
|
Can you link all relevant information in the description so that it can be navigated from the PR? |
There was a problem hiding this comment.
LGTM. Also, I think it is important to document (in release note and wiki) the fact that difficulty bomb delays are cumulative (I would have make the mistake of thinking it is not). Do :
"difficultyBombDelays": {
"0xC3500": 3000000,
"constant_bl": 2000000
},and not
"difficultyBombDelays": {
"0xC3500": 3000000,
"constant_bl": 5000000
},(constant_bl being constantinople start block value).
5chdn
added
A8-looksgood 🦄
| "eip100bTransition": "0x0", | ||
| "eip649Transition": "0x0" | ||
| "difficultyBombDelays": { | ||
| "0": 3000000 |
There was a problem hiding this comment.
can you add the 1234 portion here for constantinople?
There was a problem hiding this comment.
I think this constantinople_test is totally unsynch (see the name), currently it's basically the byzantium one. I could indeed be a good idea to get it ready for actual constantinople (if all pr are merged).
* rpc(debug_getBadBlocks): fix test (openethereum#9502) * Generalized blockReward and difficultyBombDelays config (openethereum#9480) * Implement multi blockReward * Implement difficultyBombDelays * Fix json crate compile * json keys can only be string * parity: print correct keys path on startup (openethereum#9501)
|
@sorpaas Can you add this to the wiki please? I believe it should be in https://github.com/paritytech/wiki/blob/master/Chain-specification.md |
|
On hive, parity went from Please send me a ping or mention when changes are made to the config/genesis spec, since several tools needs to be updated; such as hive, evmlab and puppeth. |
|
Really sorry @holiman. Will make sure to ping you next time. |
|
Yeah no hard feelings, just a reminder :) |
Replaces #9187. Rel #8427
Make
blockRewardconfig in ethash to acceptmulti, and adddifficultyBombDelaysconfig. Removes EIP649 configurations.